Skip to content

Motif estiamtion #12

Merged
merged 14 commits into from
Dec 20, 2018
Merged

Motif estiamtion #12

merged 14 commits into from
Dec 20, 2018

Conversation

renewiegandt
Copy link
Collaborator

Fix for issue '#11'.
Improved documentation for the script 'bed_to_fasta.R'.

@HendrikSchultheis HendrikSchultheis mentioned this pull request Dec 19, 2018
35 tasks
@renewiegandt
Copy link
Collaborator Author

renewiegandt commented Dec 19, 2018

3c4f733:
Added fix for bugs occurring in python script get_best_motif.py:

  • The output is now in MEME-format
  • Removed header from the last line

Additionally, the documentation was updated.

Copy link
Collaborator

@HendrikSchultheis HendrikSchultheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far but apart from the typos can you please check if your scripts work if the provided bed has a header.

parser.add_argument("output", help="Output file")
parser.add_argument("num", help="Number of motifs parsed from file")
args = parser.parse_args()
return args

# write lines of file till certain line (MOTIF + [num])
'''
The script has to functions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 8389226

The script has to functions:
1. Writing lines of file till certain line (MOTIF + [num])
2. Converting GLAM2 output to minimal meme-format
@params meme STING Path to 'meme' file generated from Meme suite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STRING

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 8389226

1. Writing lines of file till certain line (MOTIF + [num])
2. Converting GLAM2 output to minimal meme-format
@params meme STING Path to 'meme' file generated from Meme suite
@parmas output STING Output file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STRING

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: 8389226

@renewiegandt
Copy link
Collaborator Author

Script can now take BED-files with and without header as input. See: 2fca158

@renewiegandt
Copy link
Collaborator Author

renewiegandt commented Dec 20, 2018

Removed snakemake from yaml-file. 4dea8e4
Updated installation description. 1a7a812

opt <- parse_args(opt_parser)

#' Splitting BED-files depending on their cluster.
#' The Sequences of each cluster are writen as an FASTA-file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

written

@renewiegandt renewiegandt merged commit 80963a3 into dev Dec 20, 2018
@renewiegandt
Copy link
Collaborator Author

fixes #11

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants